-
Notifications
You must be signed in to change notification settings - Fork 29
Version 1 - User Guide for WRD by Dancho and Desi #1780
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
* added Linear Gauge * Apply suggestions from code review * remove blank lines * remove unused images --------- Co-authored-by: Yordan <[email protected]> Co-authored-by: Yordan Mitev <[email protected]>
* after review part 1 * addded draft articles for review part 2 * fix broken links * small fixes * fix broken links * Review and edit GS article * Restore app-tour.md with video * Apply suggestions from code review * Add links --------- Co-authored-by: Yordan Mitev <[email protected]> Co-authored-by: Yordan <[email protected]>
* components, map, tables after review * charts after review * fix renamed slugs * Update tables.md * applied review part 3 * Update data-sources.md
* Reuploaded videos * link to the demo https://demos.telerik.com/reporting/designer * Changes for the choropleth - no video will be provided due to a bug * charts reuploaded videos * map and bar chart reuploaded * Applied Dancho's suggestions * Remove the slugs from DataSources article * Update item style --------- Co-authored-by: Yordan <[email protected]>
…ik/reporting-docs into wrd-user-guide-with-videos
Dess, I've created a PR with the modified .md files and a detailed comments for my changes here: |
* chore: fix typos and grammar errors - fixed a few typos, grammar errors, and some incorrect statements. * Apply suggestions from code review * Apply suggestions from review - components.md * Apply suggestions from review - components.md * Apply suggestions from review - components.md * Apply suggestions from review - components.md * Aply suggestions from review - report-items.md * Apply suggestions from review - report-items.md * Apply suggestions from review - maps.md --------- Co-authored-by: Yordan <[email protected]>
@ighristov, the WebServiceDataSource is adjusted to use the https://demos.telerik.com/reporting/api/data/productsales. Hence, the Getting Started gif video and respective screenshots are recaptured. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You have done tremendous amount of work with a lot of diligence and attention to detail. Thank you! It is a solid start of our end-users onboarding experience. Videos are easy to consume and follow.
I have left inline comments - some smaller, some a bit more substantial. Please consider each one and apply up to your preference.
Bigger considerations:
- I miss the Assets Manager concept and how to use it - To organize your reports and the rest of the resources , and then to consume the assets, for example, when setting a Value for PictureBox.
- I miss the WRD Preferences explanation, no matter these are kind of trivial, it might be helpful to know for example that drag-drop to move and resize sticks to a grid (and the grid size is determined in a Report property), and the items snap to each other and these can be controlled.
- (this is also present as inline comment) I miss the Shared Data Sources concept. It is quite powerful concept allowing business org to separate responsibilities of data retrieval setup and data consumption in visual reports.
Please apply the smaller comments and merge. I click Approve. The rest should be a separate PR. When ready, please ask for review.
@elkinmilen, thank you for the provided feedback. It was all relevant and correct, so I addressed all of your comments. I am sharing the draft plan for the next version:
|
@ighristov, if you have any other comments, please let me know. Otherwise, I would appreciate it if you could approve the PR. Thank you |
No description provided.